Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The scanner does not follow symlinks #20

Closed
tereteru opened this issue Oct 26, 2021 · 5 comments
Closed

The scanner does not follow symlinks #20

tereteru opened this issue Oct 26, 2021 · 5 comments

Comments

@tereteru
Copy link

home-gallery does not seem to detect symlinked pictures. When using a directory full of them, the scan ends almost instantly, and nothing is added to the gallery.

@xemle
Copy link
Owner

xemle commented Oct 26, 2021

That is true by now. I will take this into account for a feature request.

If you are a developer you can try to change the indexer in https://github.com/xemle/home-gallery/blob/master/packages/index/src/walker.js#L25 and change the fs.lstat() call to fs.stat(). By theory it should solve your problem.

@tereteru
Copy link
Author

tereteru commented Oct 29, 2021

After changing fs.lstat to fs.stat, the pictures seem to be detected. However, no thumbnails are created... Would you have any idea how to fix this?

@xemle
Copy link
Owner

xemle commented Oct 30, 2021

I could not reproduce your issue with following test

  • Create a source dir with symlinks of a file and a dir and a file outside of the source root
dira/filea.png
dirb -> dira
fileb.png
filec.png -> fileb.png
filed.png -> ../filed.png
  • Bootstrap the gallery with current master: Only 2 files dira/filea.png and fileb.png are shown
  • Changed the fs.lstat to fs.stat and build the source again
  • Update the gallery: 3 files are shown including filed.png

Could you describe what you did differently?

@tereteru
Copy link
Author

Hi! Sorry for the late reply. I didn't delete the database at first, but after doing so, it works fine. Thanks a lot!

@xemle
Copy link
Owner

xemle commented Dec 19, 2023

Symbolic links are now followed by #107 (> v1.14.4)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants