Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nv2a 0x97 -> 0x1d78 (glEnable(GL_DEPTH_CLAMP)?) unhandled #709

Open
dracc opened this issue Feb 2, 2022 · 4 comments
Open

nv2a 0x97 -> 0x1d78 (glEnable(GL_DEPTH_CLAMP)?) unhandled #709

dracc opened this issue Feb 2, 2022 · 4 comments
Labels
bug Something isn't working

Comments

@dracc
Copy link
Contributor

dracc commented Feb 2, 2022

Title

https://xemu.app/titles/4d53006e
https://xemu.app/titles/53430007

Bug Description

According to the debug output, 0x97 -> 0x1d78 is unhandled.
In the NV20 nouveau sources, this instruction is 3D_DEPTH_CLAMP.

The parameter of the call has so far been observed as one of the following:
0x1, 0x10

Expected Behavior

The NV2A instruction 0x1D78 should be handled.

xemu Version

0.6.2-55-gcaf84884c4

System Information

N/A

Additional Context

No response

@dracc dracc added the bug Something isn't working label Feb 2, 2022
@Triticum0
Copy link

Also, affect rolling, 0x1
https://xemu.app/titles/53430007/#Rolling

@jackchentwkh
Copy link

NV097_SET_ZMIN_MAX_CONTROL 0x00001D78

@abaire
Copy link
Contributor

abaire commented Jul 18, 2023

@abaire
Copy link
Contributor

abaire commented Jul 22, 2023

Tests: https://github.com/abaire/nxdk_pgraph_tests/blob/main/src/tests/z_min_max_control_tests.cpp

More work may be necessary to figure out the "IGNORE_W" bit mentioned in the nxdk code. It didn't have any effect on my test cases, but I also didn't do a truly exhaustive attempt to make it work.

HW results: https://github.com/abaire/nxdk_pgraph_tests_golden_results/wiki/Results-ZMinMaxControl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants