aws-gate bootstrap is broken

[alanjds]

I upgraded aws-gate and started to get errors. I guess is because, after #41 got pushed, it no longer accept session-manager-plugin to be provided by the host system. However, most of our users already have it installed by other ways.

OSError: session-manager-plugin not found

Trying to aws-gate bootstrap gives error because the needed folder is not yet created

$ aws-gate -v bootstrap
[Errno 2] No such file or directory: '/Users/alanjds/.aws-gate/bin'

After creating manually, the installation can succeed:

$ mkdir -p /Users/alanjds/.aws-gate/bin
$ aws-gate -v bootstrap
1.1.26.0
session-manager-plugin (version None) installed successfully!

After #41, aws-gate no longer accept the plugin to be provided by system.
For curiosity, why is it allowing only owned version to be used?

What about allowing usage of existing one if available, maybe with a deprecation or warning message?

[xen0l]

Hi @alanjds ,

this is weird because the folder creation is contained here: https://github.com/xen0l/aws-gate/blob/master/aws_gate/bootstrap.py#L69-L71, so the folder should get created in the case it does not exist. Could you tell me how can I reproduce the issue? If you set GATE_DEBUG environment variable to something, it will provide more verbose output. Pasting that would be also helpful.

Only problem I found was the broken output (version being printed on different line and (Version None) in the subsequent line) from https://github.com/xen0l/aws-gate/blob/master/aws_gate/bootstrap.py#L18, where capture_output=True is missing, which I will add in the upcoming days alongside with a test to avoid this in the future.

As far as own version of plugin is concerned, the idea is that aws-gate will try to always use local copy if available (done via putting ~/.aws-gate/bin into the PATH at https://github.com/xen0l/aws-gate/blob/master/aws_gate/utils.py#L94). All the places are calling session-manager-plugin. If there is a call with a full path, it's certainly a bug and not intended behaviour. The reason why I implemented bootstrap was to have a simple install/update mechanism of the plugin (however, I am not very happy as there is no way to verify the checksum of the plugin as it is not published anywhere). I certainly intend to keep support for running non-aws-gate copies of the plugin for the foreseeable future.

[virgilwashere]

This is broken for me too on Ubuntu.

I will try and provide at least a bash version of a suitable Ubuntu bootstrap for you to use...my python-fu < bash-fu

[xen0l]

@virgilwashere bootstrap is supported only on mac os. I plan Linux support in the future.