Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move the applying of MeterFilters to the MeterRegistryRegistrar #6

Merged
merged 1 commit into from
Aug 12, 2019
Merged

Move the applying of MeterFilters to the MeterRegistryRegistrar #6

merged 1 commit into from
Aug 12, 2019

Conversation

kerkhofsd
Copy link
Contributor

The problem was that the applying of the MeterFilters was associated with the registering of the MeterBinders. This should be done on the MeterRegistry level, before registering the MeterRegistry in the global CompositeMeterRegistry

@kerkhofsd kerkhofsd requested a review from tgeens August 12, 2019 08:04
@kerkhofsd kerkhofsd merged commit 57942cf into master Aug 12, 2019
@kerkhofsd kerkhofsd deleted the fix-meterfilter branch August 13, 2019 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgeens tgeens tgeens approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kerkhofsd @tgeens