Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for vive trackers #136

Closed
joreg opened this issue Aug 24, 2018 · 2 comments
Closed

support for vive trackers #136

joreg opened this issue Aug 24, 2018 · 2 comments

Comments

@joreg
Copy link
Contributor

joreg commented Aug 24, 2018

helo,

i want to add support for vive-trackers. before i go full pullrequest, here my thoughts:

to my understanding those would be unique to OpenVR but still they would be added to the VRDevice class. right?

so in VRDevice.cs right next to:
public abstract TouchController LeftHand { get; }
i would add a
public abstract Tracker[] Trackers { get; }

i'd add an abstract Tracker class which would be similar to the TouchController class and would add an implementation for it for OpenVR and empty implementations for the other vr-sdks.

please let me know if this is going in the right direction or not or if there other things to consider?

@xen2
Copy link
Member

xen2 commented Aug 27, 2018

Thanks for offering help.
Sure, sounds good to give it a try with this design.

@joreg
Copy link
Contributor Author

joreg commented Sep 24, 2018

here is my PR #213

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants