New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audible clicks at the end of encoded sound effects #235

Closed
guygodin opened this Issue Oct 16, 2018 · 3 comments

Comments

Projects
None yet
4 participants
@guygodin
Copy link

guygodin commented Oct 16, 2018

Release Type: GitHub

Version: 3.0.0.5

Platform(s): Android

Describe the bug
Encoded sound effects have audible clicks at the end.

To Reproduce
Steps to reproduce the behavior:

  1. Add a sound effect with a short wav (1s length)
  2. Build project, deploy and programmatically play the sound.
  3. The sound will click when it reaches the end

Expected behavior
There shouldn't be pops or clicks in encoded sounds

Additional context
I've looked into the SoundAssetCompiler and tried to remove metadata from the generated temp file (by passing "-map_metadata -1" to ffmpeg. I've also made sure the source sound didn't have any clicks in the original signal. I've tried increasing the length of the source wav (with silence at the beginning and end of the signal). I've also double checked that there are no uncleared buffers in the SoundAssetCompiler code. Tried 3 different Android devices running on different versions. I'm running out of ideas. The sounds always produce a click at the end when played back. Only tested on Android as my project doesn't run on Windows. Any help would be appreciated. Thanks!

@guygodin

This comment has been minimized.

Copy link
Author

guygodin commented Oct 16, 2018

Here's an example of sound which will reproduce the bug:
Click.zip

@Kryptos-FR

This comment has been minimized.

Copy link
Collaborator

Kryptos-FR commented Oct 17, 2018

Could be related to compression of very short wave sounds. I think in those case, it is better to not compress them.

Also @xen2 do we still use Opus/Celt for sounds? Or did we move to only use ffmpeg in all cases?
https://doc.xenko.com/latest/en/manual/audio/audio-asset-properties.html probably needs to be amended.

@mrboni

This comment has been minimized.

Copy link

mrboni commented Oct 18, 2018

I'm getting clicks (at the loop point) when looping sounds of any duration, and either compressed or uncompressed

@xen2 xen2 self-assigned this Nov 15, 2018

@xen2 xen2 closed this in 2cb682d Nov 15, 2018

xen2 added a commit that referenced this issue Nov 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment