Skip to content
This repository has been archived by the owner on Oct 21, 2022. It is now read-only.

Add file type checking to planex-fetch #123

Closed
euanh opened this issue Feb 20, 2015 · 1 comment · Fixed by #193
Closed

Add file type checking to planex-fetch #123

euanh opened this issue Feb 20, 2015 · 1 comment · Fixed by #193
Assignees
Milestone

Comments

@euanh
Copy link
Contributor

euanh commented Feb 20, 2015

planex-downloader checked whether the result of a download looked like an archive, and retried the download if it didn't. planex-fetch should do the same thing.

There is a Python library to wrap around libmagic, but it is more or less as ugly as just shelling out to file, as downloader used to do.

@simonjbeaumont
Copy link
Contributor

Removing bug label now fetch has been fixed to not blat the file in the failure case. The enhancement suggestion remains valid.

@simonjbeaumont simonjbeaumont self-assigned this Mar 31, 2015
@euanh euanh modified the milestone: 0.8.0 Apr 1, 2015
@euanh euanh modified the milestones: 0.7.1, 0.8.0 May 26, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants