Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting full size image URL is broken #46

Closed
Skiewuff opened this issue Sep 12, 2020 · 2 comments
Closed

Getting full size image URL is broken #46

Skiewuff opened this issue Sep 12, 2020 · 2 comments

Comments

@Skiewuff
Copy link

Should be using //d2.facdn.net/art/ now:

image_url="$prefix$(grep --only-matching --max-count=1 ' href="//d2.facdn.net/art/.+">Download' "$tempfile" | cut -d '"' -f 2)"

@Skiewuff
Copy link
Author

Seems like FA keeps changing the host prefix. Probably depends on server status. So a smart script would check d.facdn and try to switch to d2.facdn if it's down

@Xerbo
Copy link
Owner

Xerbo commented Sep 26, 2020

The python version is much more resilient to changes like this due to the fact that it uses a real HTML parser instead of regex and string splitting, I should really consider moving it into master and deprecating the bash version.

@Xerbo Xerbo closed this as completed Jun 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants