Exception during finalize of Statement/PreparedStatement

[b3nn0]

Hi,
I have code that basically does this:

• Open DB Connection
• Create prepared statements and use them
• Close prepared statements
• Close DB Connection

However, I'm always getting exceptions when the next GC run occurs:

org.sqlite.SQLiteException: [SQLITE_ERROR] SQL error or missing database (Connection is closed)

The reason seems to be quite simple: Finalize of the prepared statements calls close(), which in turn calls CoreStatement.internalClose().
Internalclose will then check if the DB is already closed, and then throw the exception.

The simplest (and IMO cleanest) solution would just be to switch these two checks in CoreStatement.java, method internalClose():

if (db.conn.isClosed())
            throw DB.newSQLException(SQLITE_ERROR, "Connection is closed");

if (pointer == 0)
            return;