Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

org.sqlite.SQLiteConfig.setDatePrecision(String) throws unnecessary S… #751

Merged
merged 1 commit into from Jul 28, 2022
Merged

org.sqlite.SQLiteConfig.setDatePrecision(String) throws unnecessary S… #751

merged 1 commit into from Jul 28, 2022

Conversation

michael-o
Copy link
Contributor

…QLException (#467)

This fixes #467

@michael-o
Copy link
Contributor Author

@gotson Here you go!

@gotson gotson self-assigned this Jul 27, 2022
PromanSEW
PromanSEW reviewed Jul 27, 2022
View reviewed changes
Copy link
Contributor

@PromanSEW PromanSEW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should remove @throws Javadoc also

@michael-o
Copy link
Contributor Author

You should remove @throws Javadoc also

You are totally right. Will do.

@michael-o
Copy link
Contributor Author

@PromanSEW Done

@gotson gotson merged commit 14d5903 into xerial:master Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PromanSEW PromanSEW PromanSEW left review comments

Assignees

@gotson gotson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

org.sqlite.SQLiteConfig.setDatePrecision(String) throws unnecessary SQLException
3 participants
@michael-o @PromanSEW @gotson