Skip to content
This repository has been archived by the owner on Nov 21, 2019. It is now read-only.

Argument mixups #30

Closed
daigo75 opened this issue Dec 2, 2014 · 2 comments
Closed

Argument mixups #30

daigo75 opened this issue Dec 2, 2014 · 2 comments

Comments

@daigo75
Copy link

daigo75 commented Dec 2, 2014

Class XeroOAuth expects arguments access_token and access_token_secret, while class OAuthSimple expects consumer_key and shared_secret. This must be tidied up, the examples are confusing enough without this "renaming" through the code.

@ronanq
Copy link
Contributor

ronanq commented Jan 1, 2015

I'm not sure what the issue here is - OAuthsimple is wrapped by the XeroOAuth class so unless you want to go digging into it, there shouldn't be any confusion here. If you do wish to have a deeper dive, then yes, that is a cost of doing so, but not a compelling reason for changing the code as far as I can see it.

There are also three different OAuth implementations supported - you seem to be looking at the private type - your assertions do not hold true for other types.

That said, if you want to give some examples referencing specific code blocks that you think are problematic, I would be happy to take a look.

@ronanq
Copy link
Contributor

ronanq commented Apr 19, 2015

Will assume this can be closed for now, but feel free to reply if you have some more details....

@ronanq ronanq closed this as completed Apr 19, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants