You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Nov 21, 2019. It is now read-only.
Class XeroOAuth expects arguments access_token and access_token_secret, while class OAuthSimple expects consumer_key and shared_secret. This must be tidied up, the examples are confusing enough without this "renaming" through the code.
The text was updated successfully, but these errors were encountered:
I'm not sure what the issue here is - OAuthsimple is wrapped by the XeroOAuth class so unless you want to go digging into it, there shouldn't be any confusion here. If you do wish to have a deeper dive, then yes, that is a cost of doing so, but not a compelling reason for changing the code as far as I can see it.
There are also three different OAuth implementations supported - you seem to be looking at the private type - your assertions do not hold true for other types.
That said, if you want to give some examples referencing specific code blocks that you think are problematic, I would be happy to take a look.
Class
XeroOAuth
expects argumentsaccess_token
andaccess_token_secret
, while class OAuthSimple expectsconsumer_key
andshared_secret
. This must be tidied up, the examples are confusing enough without this "renaming" through the code.The text was updated successfully, but these errors were encountered: