Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Npm.depends with a github tarball url #48

Closed
queso opened this issue Mar 17, 2014 · 6 comments · Fixed by #59
Closed

Support Npm.depends with a github tarball url #48

queso opened this issue Mar 17, 2014 · 6 comments · Fixed by #59

Comments

@queso
Copy link

queso commented Mar 17, 2014

When adding a package with a Npm.depends call like this:

Npm.depends({"sportsdata" : "https://github.com/BeDifferential/node-sportsdata/tarball/0b3cac46aa357c194c72645bde72f3ce9b757705"});

It seems that demeteorizer is still pulling the package from Npmjs.org, because the code I added in my github branch is missing. I added a call of getGameStatsAndScores (https://github.com/BeDifferential/node-sportsdata/commit/0b3cac46aa357c194c72645bde72f3ce9b757705) and Modulus is showing this in the logs:

Exception in setInterval callback: TypeError: Object #<Object> has no method 'getGameScoreAndStats'
    at checkGame (server/gameData.coffee:50:19)
    at server/gameData.coffee:68:4
    at Array.forEach (native)
    at Function._.each._.forEach (packages/underscore/underscore.js:105)
    at findRunningGames (server/gameData.coffee:67:4)
    at _.extend.withValue (packages/meteor/dynamics_nodejs.js:35)
    at packages/meteor/timers.js:6

The project is fantasyhub-11301.onmodulus.net for reference.

@queso
Copy link
Author

queso commented Mar 17, 2014

Looks like meteor supports any tar gzipped url now: meteor/meteor#1686

@Dsyko
Copy link

Dsyko commented May 1, 2014

I think this may now be a more pressing issue with the release of 0.8.1, which depends on un-released NPM packages (css-parse and css-stringify) see here

I know that the modulus CLI actually depends on an older version of Demeteorizer but the newest 0.8.1 release of Meteor is no longer deployable to Modulus using the CLI because it fails due to dependencies on these un-released packages

Here is the error I am seeing when running the demeteorized version of my Meteor app

npm ERR! Error: version not found: 2.0.0 : css-parse/2.0.0

@timmyg
Copy link

timmyg commented May 1, 2014

+1

@queso
Copy link
Author

queso commented May 2, 2014

Any word on this? This blocks upgrading apps to 0.8.1, which is a fix for an oAuth security issue.

@timmyg
Copy link

timmyg commented May 2, 2014

Upgrade and it should be supported now, they just tweeted about it. Trying
it now.

https://github.com/onmodulus/demeteorizer

@timmyg
Copy link

timmyg commented May 2, 2014

Im guessing they updated it on their server since I forget the demeteorize
it themselves on deploy.

On Fri, May 2, 2014 at 2:07 PM, Tim Giblin timmyg13@gmail.com wrote:

Upgrade and it should be supported now, they just tweeted about it.
Trying it now.

https://github.com/onmodulus/demeteorizer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants