Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fails when using the scraperjs dependency #70

Closed
InconceivableDuck opened this issue Sep 10, 2014 · 1 comment · Fixed by #74
Closed

Fails when using the scraperjs dependency #70

InconceivableDuck opened this issue Sep 10, 2014 · 1 comment · Fixed by #74

Comments

@InconceivableDuck
Copy link
Contributor

Brings in a dependency named "sockjs-client@0.0.0-unreleasable", which is not in npm.

https://github.com/BigDSK/meteor-modulus-scraperjs
@BigDSK
Copy link

BigDSK commented Sep 17, 2014

ref: #73

fiveisprime pushed a commit that referenced this issue Sep 19, 2014
Adds the ability to filter invalid modules
26a2d14 
Adds a constant that includes the names of modules that Meteor uses
which are not present in the npm registry. These modules are skipped
when building the package.json for the project.

Closes #70 #71 and #73

Includes fixes plucked from #73 (thanks @BigDSK <3).
@fiveisprime fiveisprime mentioned this issue Sep 19, 2014
Merged
@ghost ghost mentioned this issue Jun 7, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adds the ability to filter invalid modules XervoIO/demeteorizer
2 participants
@BigDSK @InconceivableDuck