Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meteor .6 dependencies missing in package.json #8

Closed
BretFisher opened this issue Apr 16, 2013 · 7 comments
Closed

Meteor .6 dependencies missing in package.json #8

BretFisher opened this issue Apr 16, 2013 · 7 comments

Comments

@BretFisher
Copy link
Contributor

After updating to latest demeteorizer and Meteor .6, it seems three default dependencies aren't making it into demeteorizer's package.json build:

sockjs
mongodb
mailcomposer

@InconceivableDuck
Copy link
Contributor

What example did you run it on?

I can find sockjs and mongodb by iterating through app/packages and looking at node_modules folders there. I couldn't find mailcomposer in the leaderboard example. Leaderboard ran fine without it, though.

@BretFisher
Copy link
Contributor Author

yea I just looked through app/packages and since I added the meteor smart package email, it's in there. Does the demeteorizer lib search though app/packages as well? Sounds like it now should.

@InconceivableDuck
Copy link
Contributor

No it doesn't currently. Should be a simple addition and it looks like that'll pick up the remaining dependencies. Nice find.

@BretFisher
Copy link
Contributor Author

would it be building an array of paths that contain node_modules, then forEach over them?

@InconceivableDuck
Copy link
Contributor

Pretty much. Once you have the list of node_modules folders, the rest of the needed logic is in the createPackageJSON function. Right now that function assumes the single node_modules folder. It can be easily changed to accept an array of folders.

@awatson1978
Copy link

+1
Would love to give Modulus.io a spin as my new hosting provider, but am running into an error with missing node fibers. Seems to maybe be related, since I'm using 0.6.2?

StackOverflow question of related issue...
http://stackoverflow.com/questions/16259649/reinstalling-node-fibers-for-a-meteor-app-on-modulus-io?noredirect=1#comment23275248_16259649

@InconceivableDuck
Copy link
Contributor

The newest version, 0.2.1, has support for Meteor 0.6.x apps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants