-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Meteor .6 dependencies missing in package.json #8
Comments
What example did you run it on? I can find sockjs and mongodb by iterating through app/packages and looking at node_modules folders there. I couldn't find mailcomposer in the leaderboard example. Leaderboard ran fine without it, though. |
yea I just looked through app/packages and since I added the meteor smart package email, it's in there. Does the demeteorizer lib search though app/packages as well? Sounds like it now should. |
No it doesn't currently. Should be a simple addition and it looks like that'll pick up the remaining dependencies. Nice find. |
would it be building an array of paths that contain node_modules, then forEach over them? |
Pretty much. Once you have the list of node_modules folders, the rest of the needed logic is in the createPackageJSON function. Right now that function assumes the single node_modules folder. It can be easily changed to accept an array of folders. |
+1 StackOverflow question of related issue... |
The newest version, 0.2.1, has support for Meteor 0.6.x apps. |
After updating to latest demeteorizer and Meteor .6, it seems three default dependencies aren't making it into demeteorizer's package.json build:
sockjs
mongodb
mailcomposer
The text was updated successfully, but these errors were encountered: