You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@itugs makes sense. I'm thinking of the proper way of setting buffer size without adding a new constructor to all Jedis instances (Pool / Cluster / Sharded / etc) but I can't come up with a solution.
@itugs another question: Would it make sense to modify this value on runtime?. Maybe we can do something like. jedis.getClient().setIOBuffer().
I'd guess that modifying that value in runtime might probably cause errors, right?
@marcosnils Runtim modification will work if it is properly handled. ie, isolate modification with communication. But IMO construction time configuration is preferred for simplicity and clarity.
I'm also checked but it is not easy if we do not add new constructors at classes.
IMO ideally it's is good to introduce configuration object like ConnectionConfig.
The buffer size of RedisOutput/InputStream is fixed as 8192, 8KB.
It is no problem if there is not much connection.
In our case, we maintain many connections concurrently and handle under 1KB.
So 8KB is too big for us, and became burden of OldGen.
RedisOutputStream
/RedisInputStream
already has configurable constructor but inConnection#connect
there is no chance to use it.The text was updated successfully, but these errors were encountered: