New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change exists command to variodic #1054
Conversation
import redis.clients.jedis.Protocol.Command; | ||
import redis.clients.jedis.Protocol.Keyword; | ||
import redis.clients.util.SafeEncoder; | ||
import static redis.clients.jedis.Protocol.Command.*; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@charsyam
Mixed define of * and specific cases in import static Command, which would be better to fix it.
Using one way would be fine, so you can just remove specific cases import statements.
@charsyam Btw, your changeset breaks indentation, which can be fixed by running Thanks for the great work! |
@charsyam
Other things are fine. Whenever you're completing your work, I'll label as |
Talking with @charsyam , I completely forgot to tell while adding new commands to Jedis.
It should be safe with ShardedJedis* cause ShardedJedis only treats singular key operations. @charsyam Sorry about the confusing. It must be documented to CONTRIBUTING.md soon. |
@charsyam @xetorthio @marcosnils |
@xetorthio @marcosnils Please review and comment. Thanks! |
FYI: exists with vargs is included to Redis 3.0.3. |
@HeartSaVioR haven't had time to review, sorry. I'll take a look tomorrow. |
Redis 3.0.3 is out. and It contains Variadic Exists. |
Since it didn't reviewed for long time, I think it's better to merge than waiting more. |
@charsyam Thanks for amazing work! I merged into master and 2.8 respectively. |
@HeartSaVioR Thanks. :) |
today, redis exists command is changed to variodic.