Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable JMX of GenericObjectPoolConfig for speed #1223

Closed
wants to merge 1 commit into from
Closed

Disable JMX of GenericObjectPoolConfig for speed #1223

wants to merge 1 commit into from

Commits on Feb 22, 2016

  1. Disable JMX of GenericObjectPoolConfig 

    When running 32 threads and every thread has a JedisCluster(), the
program will spend more than 30 seconds to init 32 JedisCluster()
instances.
The reason is in commons-pool-2.4 :

    GenericObjectPool() --> BaseGenericObjectPool() --> jmxRegister()

the jmxRegister() will spend a lot of time to register MBean because
it always use the same Instance name and have to loop many turns.

Because users can't affort minutes to init multi-instances of
JedisCluster(), I suggest to defaultly disable JMX in JedisCluster().
    @RobinDong
    RobinDong committed Feb 22, 2016
    Copy the full SHA
    12ccb04 View commit details
    Browse the repository at this point in the history