Jedis.close() should call super.close() #1730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because there could be something more happening in BinaryJedis.close()
cpeeyush
approved these changes
Jan 9, 2018
|
@sazzad16 @marcosnils LGTM |
|
can merge now? it is tiny change without issue @sazzad16 @marcosnils |
|
I use jedis-client-2 .7.3, why the number of connections has been soaring and can not be released. |
|
LGTM! |
sazzad16
added a commit
that referenced
this pull request
Nov 27, 2018
Because there could be something more happening in BinaryJedis.close()
sazzad16
added a commit
that referenced
this pull request
Nov 27, 2018
Because there could be something more happening in BinaryJedis.close()
|
Merged into master, 2.10, 2.9. |
joyang1
pushed a commit
to joyang1/jedis
that referenced
this pull request
Dec 27, 2018
Because there could be something more happening in BinaryJedis.close()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because there could be something more happening in BinaryJedis.close()