Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify cluster related exceptions #1770

Merged
merged 1 commit into from Feb 13, 2018

Conversation

sazzad16
Copy link
Collaborator

  • Add JedisClusterOperationException. When JedisClusterException is not because of a direct response from Redis (aka JedisDataException), this JedisClusterOperationException is to be used instead.

  • JedisClusterMaxRedirectionsException is renamed to JedisClusterMaxAttemptsException. Because this is not thrown after limited redirections but limited attempts. Also, it is now a subclass of JedisClusterOperationException instead of JedisDataException.

- Add JedisClusterOperationException. When JedisClusterException is not because of a direct response from Redis (aka JedisDataException), this JedisClusterOperationException is to be used instead.

- JedisClusterMaxRedirectionsException is renamed to JedisClusterMaxAttemptsException. Because this is not thrown after limited redirections but limited attempts. Also, it is now a subclass of JedisClusterOperationException instead of JedisDataException.
@sazzad16 sazzad16 added this to the 3.0.0 milestone Feb 11, 2018
@sazzad16
Copy link
Collaborator Author

@HeartSaVioR @marcosnils

Copy link
Contributor

@marcosnils marcosnils left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!.

@sazzad16 sazzad16 merged commit df04053 into redis:master Feb 13, 2018
@sazzad16
Copy link
Collaborator Author

Merged into master.

@sazzad16 sazzad16 deleted the max-redirections-exception branch February 13, 2018 04:09
joyang1 pushed a commit to joyang1/jedis that referenced this pull request Dec 27, 2018
- Add JedisClusterOperationException. When JedisClusterException is not because of a direct response from Redis (aka JedisDataException), this JedisClusterOperationException is to be used instead.

- JedisClusterMaxRedirectionsException is renamed to JedisClusterMaxAttemptsException. Because this is not thrown after limited redirections but limited attempts. Also, it is now a subclass of JedisClusterOperationException instead of JedisDataException.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants