Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add function of Redis Bloom Filter for Jedis and Jedis Cluster #1905

Closed
wants to merge 5 commits into from

Conversation

joyang1
Copy link

@joyang1 joyang1 commented Nov 26, 2018

add function of Redis Bloom Filter for Jedis and Jedis Cluster

@marcosnils
Copy link
Contributor

Is this part of a Redis module?. We don't usually add first class functions for Redis modules to the API.
You can extend Jedis and wrap it around a custom library for that.

@smadasu @gkorland thoughts?

@joyang1
Copy link
Author

joyang1 commented Nov 27, 2018

I think redis bloom filter is use usually now. So I hope you can add this functions.
But if you think this is not necessary, I can only wrap Jedis around a custom library.
thanks~~~
@marcosnils

@gkorland
Copy link
Contributor

@joyang1
Copy link
Author

joyang1 commented Nov 27, 2018

@gkorland , I know this, this I can customize, but I want to use JedisCluster for Rebloom.
So I need use Jedis.
I think this is necessary to integrated with Jedis.
But if you think this is not necessary, I can only wrap Jedis around a custom library.
thanks~~~

@gkorland
Copy link
Contributor

I think you should PR JReBloom, and not Jedis.

@joyang1
Copy link
Author

joyang1 commented Nov 27, 2018

@gkorland I know, but JedisCluster can't customize, JedisCluster use Jedis class to read Redis server.
So I Should't PR JReBloom.
I hope you can let us to customize JedisCluster.
Thanks~~~

@joyang1
Copy link
Author

joyang1 commented Nov 27, 2018

@gkorland I want to do this PR in JReBloom.
But you need to let me Customize JedisCluster.
It's OK?

@marcosnils
Copy link
Contributor

What about extending JedisCluster in JReBloom and add the methods here?

@joyang1
Copy link
Author

joyang1 commented Nov 27, 2018

Because in JedisCluster, I can't customize commands.

@gkorland gkorland closed this Dec 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants