Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify license, potentially replace Fatal_Error #12

Closed
mk-pmb opened this issue Apr 19, 2022 · 3 comments
Closed

Clarify license, potentially replace Fatal_Error #12

mk-pmb opened this issue Apr 19, 2022 · 3 comments

Comments

@mk-pmb
Copy link

mk-pmb commented Apr 19, 2022

Between the lines // FROM programs/xlsfonts/dsimple.c and // END FROM, we currently have the functions

  • Fatal_Error
  • Window_With_Name
  • Select_Window_Args
  • Select_Window_Mouse

However, I can only find Fatal_Error in Ubuntu's source of xlsfonts/dsimple.c.

Are the others your own creation? Then we should adjust the END FROM marker.

Even better would be to write our own Fatal_Error function as well, because I can't currently see license compatibility.

Maybe it would suffice to have Fatal_Error be a trivial function that just prints the error message, and a comment for where to find a fancier function (e.g. the Ubuntu link above) if someone wants to make a temporary debug build.

@mk-pmb
Copy link
Author

mk-pmb commented Apr 19, 2022

It might even be possible to add a CLI option to dynamically load the fancy Fatal_Error from xlsfonts on systems where the latter is installed.

@mk-pmb
Copy link
Author

mk-pmb commented May 11, 2022

A fork that entirely omits the section in question is now available.

@mk-pmb mk-pmb closed this as completed May 11, 2022
@xeyownt
Copy link
Owner

xeyownt commented May 12, 2022

TBH I have no idea of the origin of the license claim since this code is not mine.
I just hosted here because I used the tool at some time, and it was nowhere to be found.
I mailed the author and never got any reaction.

I doubt however that the claim was for the fatal_error function because this function is too generic (you find these everywhere).

But happy to see the project being forked ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants