This repository has been archived by the owner on Sep 11, 2023. It is now read-only.
Add by-reference array accessors to EnumMap #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An alternative would be to simply expose the `array` field as `pub`: whatever works. I went with this as it allows adding simple docs at the same time. Fixes KamilaBorowska#26.
Fuuzetsu
force-pushed
the
array-accessors
branch
from
3794518
to
acbae9e
Compare
|
In hind-sight, these probably should have been |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An alternative would be to simply expose the
arrayfield aspub: whatever works. I went with this as it allows adding simple docs at the same time.Fixes #26.