Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix call-signature related own PendingDeprecationWarning in tests #218

Closed
xflr6 opened this issue Mar 18, 2024 · 6 comments
Closed

Fix call-signature related own PendingDeprecationWarning in tests #218

xflr6 opened this issue Mar 18, 2024 · 6 comments
Assignees
Labels

Comments

@xflr6
Copy link
Owner

xflr6 commented Mar 18, 2024

E.g. in https://github.com/xflr6/graphviz/actions/runs/8317979263

PendingDeprecationWarning: The signature of save will be reduced to 1 positional arg ['filename']:
pass directory='doctest-output/round-table.gv' as keyword arg(s)
    filepath = self.save(filename, directory=directory, skip_existing=None)

Possibly related to e5578d3.

@xflr6 xflr6 self-assigned this Mar 18, 2024
@xflr6 xflr6 mentioned this issue Mar 18, 2024
@mtelka
Copy link

mtelka commented Mar 19, 2024

To suppress warnings it is recommended to test with -W ignore:"The signature of":PendingDeprecationWarning.

@kloczek
Copy link

kloczek commented Mar 19, 2024

Is it not possible to fix that warning instead calming it down? 🤔 (just asking)

@mtelka
Copy link

mtelka commented Mar 19, 2024

Sure, it is and I believe it will be fixed by @xflr6 soon.

@xflr6 xflr6 added the bug label Mar 21, 2024
@xflr6
Copy link
Owner Author

xflr6 commented Mar 21, 2024

Sorry for the warning noise (my bad), new relase is underway.

@xflr6
Copy link
Owner Author

xflr6 commented Mar 21, 2024

Fixed in https://pypi.org/project/graphviz/0.20.3/

Gives us some time to work on a proper fix.

@xflr6 xflr6 closed this as completed in f029709 May 13, 2024
@xflr6
Copy link
Owner Author

xflr6 commented May 13, 2024

Should be fixed by f029709

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants