Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Gtk3 instead of Gtk2 #48

Closed
bilelmoussaoui opened this issue Jan 17, 2017 · 15 comments
Closed

Use Gtk3 instead of Gtk2 #48

bilelmoussaoui opened this issue Jan 17, 2017 · 15 comments

Comments

@bilelmoussaoui
Copy link

Gtk2 is old and ugly! Using Gtk3 will provide better experience for the user!
I would like to contribute and use Gtk3 with Python3 instead of Gtk2 with Python2.7 also moving from gconf to dconf which will fix other issues too :)

@ntc2
Copy link
Member

ntc2 commented Jan 17, 2017

I'm open to this, but I think the gconf to dconf transition (Issue #34) should be a separate pull request, and is higher priority. Does @Kilian have anything to say about your proposed Python2/Gtk2 to Python3/Gtk3 transition?

@bilelmoussaoui
Copy link
Author

Here's the current widget ;) It's storing the data on dconf instead of gconf.
screenshot from 2017-01-17 09-36-42
screenshot from 2017-01-17 09-36-32

@Kilian
Copy link
Member

Kilian commented Jan 17, 2017

I think gconf -> dconf is best done separately.

With regard to going from py2/gtk2 to py3/gtk3: I'm more than fine with that (thought it's not an urgent thing: It's nice to have). Hopefully it will not need too much change in the "business logic". We need to check if the python indicator library we use still works, or if we need to switch that out as well.

@bilelmoussaoui
Copy link
Author

It still works ;)

@bilelmoussaoui
Copy link
Author

Anyway, i've done with this! It works perfectly i've also added some new stuff! Translations using gettext, appdata file(to show the information about the application indicator in any application store on linux). Build using meson instead of the default installation method, Gtk2 to Gtk3 and GConf to DConf ;)
As Ubuntu does not support client side decoration, i've also added a different settings widget based on Gtk.Notebook instead of Gtk.Stack & Gtk.StackSwitcher ;)
I will create a PR tomorrow once i'm sure that everything works perfectly! I've also fixed #34 and #26

@Kilian
Copy link
Member

Kilian commented Jan 18, 2017

that sounds excellent! :)

@ntc2 ntc2 removed the needs info label Jan 29, 2017
@ntc2
Copy link
Member

ntc2 commented Jan 29, 2017

@bil-elmoussaoui, any news on that pull request? ;)

@bilelmoussaoui
Copy link
Author

@ntc2 Sorry for the delay, i was a little busy those last days. It will be ready before this weekend

@burningalchemist
Copy link

@bil-elmoussaoui any updates regarding the pull request? :)

@benmccann
Copy link

@bil-elmoussaoui would you be able to send the PR for this?

@bilelmoussaoui
Copy link
Author

Sorry guys for the long long delay. I was super busy, and i'm preparing some finals to pass in August/September.
The code isn't fully ready yet. I can either share it here or if you guys are patient enough, i can clean it a bit and make everything works in the next few weeks and submit a PR

@ntc2
Copy link
Member

ntc2 commented Jul 6, 2017

@bil-elmoussaoui: how about you submit your current code now as a PR, with the expectation that you will clean it up during the next few weeks? That way we can take a look sooner and try it out.

@ghost
Copy link

ghost commented May 5, 2018

@bilelmoussaoui Hi. Are you still working on this as in 2018?

@ntc2
Copy link
Member

ntc2 commented Jun 1, 2018

@bilelmoussaoui : how about you submit the code now as a PR, in whatever form it's in, with no expectations at all ;) We can take care of fixing it up and merging it.

@ntc2
Copy link
Member

ntc2 commented Dec 27, 2018

Thanks to @LaBatata101, fluxgui has been ported to Python 3 and GTK+ 3 in #112.

@ntc2 ntc2 closed this as completed Dec 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants