Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Optional) text does not appear for optional fields which are shown when a list item is selected #31

Closed
andymoody opened this issue Jul 1, 2020 · 1 comment
Labels
good first issue Good for newcomers

Comments

@andymoody
Copy link
Contributor

andymoody commented Jul 1, 2020

To reproduce:

  1. Add a list with options 'A' and 'B'. Add a 'Text Field' component to option A, and make the Text Field component optional.
  2. Add a page with a radio group using the list defined in step 1.
  3. Access the page in the runner and select Option A.
  4. The text field is displayed with no '(Optional)' text.

Expected outcome:

The text field should be displayed with (Optional) text

Additional Information:

From a bit of investigation it appears that the issue is actually in designer - when saving in list-edit.js we don't attempt to retrieve whether the optional / optionalText fields are set. It appears that if we do try to retrieve this we currently receive no context information about which conditional input of which list item this relates to.

@andymoody andymoody created this issue from a note in XGov Form Builder kanban (Backlog) Jul 1, 2020
@andymoody andymoody moved this from Backlog to In progress in XGov Form Builder kanban Jul 1, 2020
@andymoody andymoody moved this from In progress to Backlog in XGov Form Builder kanban Jul 1, 2020
@aslam-cyb aslam-cyb self-assigned this Jul 14, 2020
@jenbutongit jenbutongit added the good first issue Good for newcomers label Sep 14, 2020
@endamccormack
Copy link
Contributor

endamccormack commented Feb 11, 2021

forms-299

p3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
No open projects
Development

No branches or pull requests

4 participants