Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contribution Graph: Using locale for weekdays #15

Closed
ankraft opened this issue May 30, 2016 · 4 comments
Closed

Contribution Graph: Using locale for weekdays #15

ankraft opened this issue May 30, 2016 · 4 comments
Labels
enhancement

Comments

@ankraft
Copy link
Contributor

ankraft commented May 30, 2016 •
edited by xhacker

The order of weekdays seems to be hard coded, where the week always starts on Sunday. Would it be possible to change this in order to support locales where the week starts on Monday?
I guess one way to achieve this could be by adding 1 to the index (in case the week starts on Monday) and doing a modulus by 7 afterwards.
It would be great if this could be implemented.
@xhacker
Copy link
Owner

xhacker commented May 31, 2016

Good point. The first day should definitely be retrieved from NSLocale. However I don’t have time recently, if you made any changes, please pull request :)

@xhacker xhacker changed the title Distribution Chart: Using locale for weekdays Contribution Graph: Using locale for weekdays May 31, 2016
@ankraft
Copy link
Contributor Author

ankraft commented May 31, 2016

Please check the pull request #16. I also added support for localised names for the weekdays.

@ankraft
Copy link
Contributor Author

ankraft commented Jun 11, 2016

Did you have a chance to look at PR #16 ?

@xhacker
Copy link
Owner

xhacker commented Jun 19, 2016

Closed via bb84675.

@xhacker xhacker closed this as completed Jun 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xhacker @ankraft