Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional parameter in config JSON to store (1) notes (2) alias override or prefix/suffix #47

Open
2 tasks
raghuvv opened this issue May 25, 2022 · 4 comments

Comments

@raghuvv
Copy link

raghuvv commented May 25, 2022

Description

add additional optional parameters in config

  1. NOTES - to store notes about the account(s) e.g. for POC of MyApp
  2. ALIAS (override/prefix/suffix) - small text string that will be displayed in place of or in addition to the account alias. E.g. "Sandbox". If possible please include Unicode support.

Other information

No response

Acknowledge

  • I may be able to implement this feature request
  • This feature might incur a breaking change
@umireon
Copy link
Contributor

umireon commented May 26, 2022

I don't think this should be implemented.

  • The NOTES field isn't needed because the configuration allows writing comments.
  • We should not have ALIAS fields as our own config. IMO using the account name stored on AWS is better.

@umireon
Copy link
Contributor

umireon commented May 26, 2022

ALIASに関しては絵文字1文字をくっつけられるようにして欲しいのかなとエスパーしました

@xhiroga
Copy link
Owner

xhiroga commented May 27, 2022

@raghuvv Thank you for your suggestion!

NOTES - to store notes about the account(s) e.g. for POC of MyApp

I have same opinion with @umireon. JSONC format for comment is enough.

ALIAS (override/prefix/suffix)

Could you tell me your problem? In my opinion, account name is enough to distinguish AWS account. When user uses AWS SSO, this extension show account name. Isn't it enough?

@raghuvv
Copy link
Author

raghuvv commented May 31, 2022

Re: ALIAS --

Account ALIAS / Account name may ne setup by the AWS account admin based on their own context,

A user may be accessing that AWS account in a different context. Example A vendor / service provider that provides services to multiple clients. Being able to add a prefix / suffix / emoji to the display name of the account may help them easily organize the accounts and separate them.

For instance a consultant might have access to AWS accounts of three different clients -- client1, client2, client3.

Each client would have their own naming convention for aliases. Some clients may have multiple AWS accounts with no standard naming.

But the consultant may still want to tag them clearly for their own reference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants