Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change assigned value for variables in dlt.lang #6

Closed
xhluca opened this issue Feb 25, 2021 · 0 comments · Fixed by #1
Closed

Change assigned value for variables in dlt.lang #6

xhluca opened this issue Feb 25, 2021 · 0 comments · Fixed by #1
Labels
enhancement New feature or request
Projects
Release v0.1.0

Comments

@xhluca
Copy link
Owner

xhluca commented Feb 25, 2021 •
edited

right now dlt.lang.ENGLISH = "en_XX" which is the fairseq language code. We should use one common notation (or keep that one) and map the "common" notation to each specific language code (fairseq, helsinki-nlp, etc.)

This will help for #2
@xhluca xhluca added the enhancement New feature or request label Feb 25, 2021
@xhluca xhluca added this to To do in Release v0.1.0 Feb 25, 2021
@xhluca xhluca changed the title Change dlt.lang's actual value Change assigned value for variables in dlt.lang Feb 26, 2021
@xhluca xhluca mentioned this issue Mar 3, 2021
Merged
@xhluca xhluca closed this as completed in #1 Mar 3, 2021
@xhluca xhluca moved this from To do to Done in Release v0.1.0 Mar 3, 2021
@xhluca xhluca reopened this Mar 11, 2021
Release v0.1.0 automation moved this from Done to To do Mar 11, 2021
@xhluca xhluca closed this as completed Mar 11, 2021
Release v0.1.0 automation moved this from To do to Done Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
No open projects
Release v0.1.0
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Major development updates xhluca/dl-translate
1 participant
@xhluca