Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorporating ISO-639 #12

Closed
xhluca opened this issue Mar 11, 2021 · 2 comments
Closed

Incorporating ISO-639 #12

xhluca opened this issue Mar 11, 2021 · 2 comments
Labels
enhancement New feature or request
Projects
Add MarianNMT v0.2.0

Comments

@xhluca
Copy link
Owner

xhluca commented Mar 11, 2021 •
edited

Might be worth considering ISO-639-1, ISO-639 Macro. This would have the added benefit of mapping endonyms as well, e.g. dlt.endonym.get("日本語") -> "ja" which would be equivalent to dlt.lang.JAPANESE -> "ja" or something like that.

Some useful links:
@xhluca xhluca added the enhancement New feature or request label Mar 11, 2021
@xhluca
Copy link
Owner Author

xhluca commented Mar 12, 2021 •
edited

Might also add ISO country codes so we'd be able to cover regional variants (e.g. "fr_CA" vs "fr_FR"). Heres the downloadable version

@xhluca xhluca added this to To Do in Add MarianNMT Mar 13, 2021
@xhluca xhluca added this to To do in v0.2.0 Mar 30, 2021
@xhluca xhluca closed this as completed Apr 7, 2021
Add MarianNMT automation moved this from To Do to Done Apr 7, 2021
@xhluca xhluca reopened this Apr 7, 2021
@xhluca
Copy link
Owner Author

xhluca commented Mar 9, 2022

Looks like this project covers pretty much what I had in mind already: https://github.com/LBeaudoux/iso639

@xhluca xhluca closed this as completed Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
No open projects
Add MarianNMT
Done
v0.2.0
To do
Milestone
No milestone
Development

No branches or pull requests
1 participant
@xhluca