Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace pypdf with pyHanko #755

Open
bgermann opened this issue Feb 16, 2024 · 2 comments
Open

Replace pypdf with pyHanko #755

bgermann opened this issue Feb 16, 2024 · 2 comments
Labels
feature request New feature or request

Comments

@bgermann
Copy link

Motivation

Both pypdf and pyHanko are dependencies. pyHanko includes a fork of PyPDF2, which is itself a fork of pypdf.

Proposed Solution

The pyHanko variants of the used pypdf objects (PdfReader, PdfWriter, PageObject) should be used.

Additional Context

Implementing this proposal enables to drop the pypdf dependency.

@bgermann bgermann added the feature request New feature or request label Feb 16, 2024
@stefan6419846
Copy link
Contributor

PyPDF2, which is itself a fork of pypdf

This is wrong for some time now: PyPDF2 has been deprecated in favor of pypdf. pyHanko does indeed include a heavily modified version of PyPDF2.

In my personal opinion, 6777fe9 should be mostly reverted and pyHanko dropped completely for a clean separation of concerns.

@bgermann
Copy link
Author

It would also be useful if pyHanko was optional instead of removing the whole feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants