Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1、MenuItem .h 修改了Item模型的初始化方法，因为index索引，是在PopMenu内部设置的，所有不需要暴露出来 - (instancetype)initWithTitle:(NSString *)title iconName:(NSString *)iconName glowColor:(UIColor *)glowColor index:(NSUInteger)index NS_DEPRECATED_IOS(2_0,2_0); 增加了一个init方法，和构造方法 - (instancetype)initWithTitle:(NSString *)title iconName:(NSString *)iconName glowColor:(UIColor *)glowColor NS_AVAILABLE_IOS(2_0); + (instancetype)itemWithTitle:(NSString *)title iconName:(NSString *)iconName glowColor:(UIColor *)glowColor NS_AVAILABLE_IOS(2_0); 2、 GlowImageView.h 修改了.m中所有方法，将c语言方法，改成了OC方法，直接对图层操作，摒弃了Quartz2D技术 3. 增加了注释，提高程序的可读性和可交换性
|
建议把每行可以显示多少个item的设为成员属性，保留初始默认值，这样就有更高的可扩展性 |
|
@YueLiXing |
|
我改的地方不多，只改了PopMenu.m Line：123 这一个地方 |
|
我记得之前是适配好的，为什么现在不行了呀？ |
|
不行你自己试试，把那个3改成2，然后放四个item上去 |
|
不是不信，我测试一下，然后再来修复 |
|
OK，我吃饭去了。。。 |
|
对了，您把光圈的效果改了吗？能呈现出来吗？ |
|
没。。 |
|
|
|
貌似这是居中吧？ |
|
能否加个QQ一起聊一下？ |
|
1223343444 |
|
两位，那个光圈效果是我修改的。。。 |
|
@JiaqiSun |
|
我还有个想法，就是能不能扩充几个item的位置，不能只是居中显示吧，希望多提供一些接口，这样的话，可扩展性会更高些 |
|
我突然想到用 UIBezierPath 来画。。。。可扩展性会不会直接爆表。。。 |
|
。。。。有点爆了。。感觉有点大材小用了，提供个扩展方法根据Frame，然后写几个常见的位置，用枚举貌似就完事了 |
|
@JiaqiSun Jack |
|
最近没时间呀。。我也在写另一个框架呢 。。。啥时候有时间了 我看看 |
|
啊啊啊啊。。。俺们要换WebSocket聊天，我也有的忙了。。。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
更改方案:
1、MenuItem .h
修改了Item模型的初始化方法，因为index索引，是在PopMenu内部设置的，所有不需要暴露出来
增加了一个init方法，和构造方法
2、 GlowImageView.h
修改了.m中所有方法，将c语言方法，改成了OC方法，直接对图层操作，摒弃了Quartz2D技术