Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit tests should test interface and only interface #25

Open
GoogleCodeExporter opened this issue May 20, 2015 · 6 comments
Open

Unit tests should test interface and only interface #25

GoogleCodeExporter opened this issue May 20, 2015 · 6 comments

Comments

@GoogleCodeExporter
Copy link

The unit tests packaged with ESAPI should only test the interface and not
contain code that is specific to the default implementations. This means
two things in particular:

1. All types should be from the API interfaces
2. Methods called on instances being tested should only reflect those in
the API

Specific tests that call methods not in the API:
* AuthenticatorTest.testSaveUsers

... more to come.

Original issue reported on code.google.com by cyounk...@gmail.com on 31 Jul 2009 at 7:46

@GoogleCodeExporter
Copy link
Author

Maybe split the tests in two. One folder for interface and one for default
implementations. That way you can still test the default implementations on a 
finer
granularity.

Original comment by eofte...@gmail.com on 10 Sep 2009 at 6:54

@GoogleCodeExporter
Copy link
Author

Original comment by manico.james@gmail.com on 1 Nov 2010 at 5:57

  • Changed state: Accepted
  • Added labels: Milestone-Release2.1

@GoogleCodeExporter
Copy link
Author

Original comment by chrisisbeef on 20 Nov 2010 at 9:14

2 similar comments
@GoogleCodeExporter
Copy link
Author

Original comment by chrisisbeef on 20 Nov 2010 at 9:14

@GoogleCodeExporter
Copy link
Author

Original comment by chrisisbeef on 20 Nov 2010 at 9:14

@GoogleCodeExporter
Copy link
Author

Original comment by chrisisbeef on 20 Nov 2010 at 9:15

  • Added labels: Build-Maven, Component-Other

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant