Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work around windows/osx gcc12 x86_64 tree-optimizer problem and add an osx/gcc12 build to Azure CI #3745

Merged
merged 55 commits into from
Sep 3, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
55 commits
Select commit Hold shift + click to select a range
9cf7075
add osx/gcc12
martin-frbg Aug 26, 2022
9c33114
Update azure-pipelines.yml
martin-frbg Aug 26, 2022
9a56f4c
Update azure-pipelines.yml
martin-frbg Aug 26, 2022
361ee24
Update Makefile
martin-frbg Aug 27, 2022
e41046a
Update azure-pipelines.yml
martin-frbg Aug 27, 2022
a97f112
Update Makefile
martin-frbg Aug 27, 2022
e9d1bc6
Update Makefile
martin-frbg Aug 27, 2022
76aaa17
Update azure-pipelines.yml
martin-frbg Aug 28, 2022
c97471e
Update Makefile
martin-frbg Aug 28, 2022
1d00dee
try disabling the GCC12+ tree vectorizer
martin-frbg Aug 28, 2022
5854530
Update azure-pipelines.yml
martin-frbg Aug 28, 2022
3da42ae
Update azure-pipelines.yml
martin-frbg Aug 28, 2022
17f8de4
Update azure-pipelines.yml
martin-frbg Aug 28, 2022
9b4a579
Update Makefile
martin-frbg Aug 30, 2022
74f2da7
Update Makefile
martin-frbg Aug 31, 2022
b8f1602
Update Makefile
martin-frbg Aug 31, 2022
ca1fa6a
Update Makefile
martin-frbg Aug 31, 2022
0daaeb2
Update Makefile
martin-frbg Aug 31, 2022
66035af
Update Makefile
martin-frbg Aug 31, 2022
2a0caf8
Update Makefile.L1
martin-frbg Aug 31, 2022
ef4110d
Update Makefile.L2
martin-frbg Aug 31, 2022
55d7469
revert
martin-frbg Aug 31, 2022
a110bef
revert
martin-frbg Aug 31, 2022
a1c3086
revert
martin-frbg Aug 31, 2022
85cb811
revert
martin-frbg Aug 31, 2022
72ea509
revert
martin-frbg Aug 31, 2022
43113a3
Update Makefile
martin-frbg Aug 31, 2022
7711eee
Update Makefile.x86_64
martin-frbg Aug 31, 2022
6d7ec34
Update Makefile.L2
martin-frbg Aug 31, 2022
e5d0749
try pragma to disable tree vectorizer
martin-frbg Sep 1, 2022
e8a9443
try pragma to disable tree vectorizer
martin-frbg Sep 1, 2022
62eef86
Update Makefile.L1
martin-frbg Sep 1, 2022
45b1dc7
disable gcc tree vectorizer
martin-frbg Sep 1, 2022
801fe19
disable gcc tree vectorizer
martin-frbg Sep 1, 2022
ce4cdd5
disable gcc tree vectorizer
martin-frbg Sep 1, 2022
ed030a0
disable gcc tree vectorizer
martin-frbg Sep 1, 2022
83568f3
disable gcc tree vectorizer
martin-frbg Sep 1, 2022
8cedac9
revert
martin-frbg Sep 3, 2022
8e16408
revert
martin-frbg Sep 3, 2022
327938a
remove -g from osx/gcc12 job
martin-frbg Sep 3, 2022
b2b31a8
Add guards around the pragma
martin-frbg Sep 3, 2022
746f6c0
Add guards around the pragma
martin-frbg Sep 3, 2022
c4b0767
Add guards around the pragma
martin-frbg Sep 3, 2022
7a93103
Add guards around the pragma
martin-frbg Sep 3, 2022
07ef20e
Add guards around the pragma
martin-frbg Sep 3, 2022
7c59443
Add guards around the pragma
martin-frbg Sep 3, 2022
002df7c
Add guards around the pragma
martin-frbg Sep 3, 2022
8c6261c
move pragma
martin-frbg Sep 3, 2022
49589a6
move pragma
martin-frbg Sep 3, 2022
7f0b14e
move pragma
martin-frbg Sep 3, 2022
c758578
move pragma
martin-frbg Sep 3, 2022
90b2d9f
move pragma
martin-frbg Sep 3, 2022
ea74832
move pragma
martin-frbg Sep 3, 2022
44a5ce3
move pragma
martin-frbg Sep 3, 2022
57b8939
remove leftover debugging code
martin-frbg Sep 3, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 8 additions & 0 deletions azure-pipelines.yml
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,14 @@ jobs:
brew update
make USE_THREADS=0 CC=gcc-10 FC=gfortran-10

- job: OSX_GCC12
pool:
vmImage: 'macOS-latest'
steps:
- script: |
brew update
make CC=gcc-12 FC=gfortran-12

- job: OSX_OpenMP_Clang
pool:
vmImage: 'macOS-10.15'
Expand Down
5 changes: 4 additions & 1 deletion kernel/x86_64/sgemv_n_4.c
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,12 @@ OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE
USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*****************************************************************************/


#include "common.h"

#if (defined(OS_DARWIN) || defined(OS_WINDOWS)) && (defined(__GNUC__) && __GNUC__ > 11)
#pragma GCC optimize("no-tree-vectorize")
#endif


#if defined(BULLDOZER) || defined(PILEDRIVER) || defined(STEAMROLLER) || defined(EXCAVATOR)
#include "sgemv_n_microk_bulldozer-4.c"
Expand Down
5 changes: 4 additions & 1 deletion kernel/x86_64/sgemv_t_4.c
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,12 @@ OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE
USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*****************************************************************************/


#include "common.h"

#if (defined(OS_DARWIN) || defined(OS_WINDOWS)) && (defined(__GNUC__) && __GNUC__ > 11)
#pragma GCC optimize("no-tree-vectorize")
#endif

#if defined(NEHALEM)
#include "sgemv_t_microk_nehalem-4.c"
#elif defined(BULLDOZER) || defined(PILEDRIVER) || defined(STEAMROLLER) || defined(EXCAVATOR)
Expand Down
5 changes: 4 additions & 1 deletion kernel/x86_64/ssymv_L.c
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,12 @@ OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE
USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*****************************************************************************/


#include "common.h"

#if (defined(OS_DARWIN) || defined(OS_WINDOWS)) && (defined(__GNUC__) && __GNUC__ > 11)
#pragma GCC optimize("no-tree-vectorize")
#endif

#if defined(BULLDOZER) || defined(PILEDRIVER) || defined(STEAMROLLER) || defined(EXCAVATOR)
#include "ssymv_L_microk_bulldozer-2.c"
#elif defined(NEHALEM)
Expand Down
5 changes: 4 additions & 1 deletion kernel/x86_64/ssymv_U.c
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,12 @@ OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE
USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*****************************************************************************/


#include "common.h"

#if (defined(OS_DARWIN) || defined(OS_WINDOWS)) && (defined(__GNUC__) && __GNUC__ > 11)
#pragma GCC optimize("no-tree-vectorize")
#endif


#if defined(BULLDOZER) || defined(PILEDRIVER) || defined(STEAMROLLER) || defined(EXCAVATOR)
#include "ssymv_U_microk_bulldozer-2.c"
Expand Down
4 changes: 3 additions & 1 deletion kernel/x86_64/zdot.c
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,11 @@ OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE
USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*****************************************************************************/


#include "common.h"

#if (defined(OS_DARWIN) || defined(OS_WINDOWS)) && (defined(__GNUC__) && __GNUC__ > 11)
#pragma GCC optimize("no-tree-vectorize")
#endif

#if defined(BULLDOZER)
#include "zdot_microk_bulldozer-2.c"
Expand Down
9 changes: 3 additions & 6 deletions kernel/x86_64/zgemv_n_4.c
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,11 @@ OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE
USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*****************************************************************************/

#include <stdlib.h>
#include <stdio.h>
#include "common.h"

#if (defined(OS_DARWIN) || defined(OS_WINDOWS)) && (defined(__GNUC__) && __GNUC__ > 11)
#pragma GCC optimize("no-tree-vectorize")
#endif

#if defined(HASWELL) || defined(ZEN) || defined (SKYLAKEX) || defined (COOPERLAKE) || defined (SAPPHIRERAPIDS)
#include "zgemv_n_microk_haswell-4.c"
Expand Down Expand Up @@ -231,10 +232,6 @@ int CNAME(BLASLONG m, BLASLONG n, BLASLONG dummy1, FLOAT alpha_r,FLOAT alpha_i,
FLOAT xbuffer[8],*ybuffer;


#if 0
printf("%s %d %d %.16f %.16f %d %d %d\n","zgemv_n",m,n,alpha_r,alpha_i,lda,inc_x,inc_y);
#endif

if ( m < 1 ) return(0);
if ( n < 1 ) return(0);

Expand Down
4 changes: 3 additions & 1 deletion kernel/x86_64/zgemv_t_4.c
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,11 @@ OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE
USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*****************************************************************************/


#include "common.h"

#if (defined(OS_DARWIN) || defined(OS_WINDOWS)) && (defined(__GNUC__) && __GNUC__ > 11)
#pragma GCC optimize("no-tree-vectorize")
#endif

#if defined(BULLDOZER) || defined(PILEDRIVER) || defined(STEAMROLLER) || defined(EXCAVATOR)
#include "zgemv_t_microk_bulldozer-4.c"
Expand Down