Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide onThumbnailClick prop #200

Closed
4muzar opened this issue Jun 21, 2017 · 3 comments
Closed

Provide onThumbnailClick prop #200

4muzar opened this issue Jun 21, 2017 · 3 comments

Comments

@4muzar
Copy link
Contributor

4muzar commented Jun 21, 2017

Hi!

This component is awesome and fits to my project nearly perfect.
But in my case I have to hide main image, show only thumbnails and enter to full screen mode on thumbnail click.

So I suggest to add onThumbnailClick and hideMainImage props. slideWrapper has to be shown on full screen mode.
Having these props, I can do the rest of work by myself.

What do you think about these features?

I can implement it and create PR.
Thank you!

@xiaolin
Copy link
Owner

xiaolin commented Jun 21, 2017

Adding a onThumbnailClick is okay, but hideMainImage is unique to your use case. You should be able to hide the the images with css.

@4muzar
Copy link
Contributor Author

4muzar commented Jun 23, 2017

Okay, I agree.
I'll add onThumbnailClick

@xiaolin
Copy link
Owner

xiaolin commented Jun 24, 2017

released in version 0.8.3

@xiaolin xiaolin closed this as completed Jun 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants