Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

May need to disable new prefs #162

Open
tomrittervg opened this issue Jul 20, 2022 · 1 comment
Open

May need to disable new prefs #162

tomrittervg opened this issue Jul 20, 2022 · 1 comment

Comments

@tomrittervg
Copy link

In https://bugzilla.mozilla.org/show_bug.cgi?id=1772345 I just enabled two new prefs that will sanitize preference strings in content processes. Some of the logic used there is "If it's string pref, and a dynamic pref - sanitize it and crash the content process if it's accessed." Dynamic Pref meaning it's not a pref specified in our preference files. Mozilla frustratingly has many of these ourselves, where we either check a pref that's usually for testing without specifying it in the preference files, or we construct a pref name at runtime and use it to store data. So I'm whittling down this list. This is pretty safe because with WebExtensions, only Mozilla has the capability to set prefs so it's just our code.

Except..... for you folks. I found the pref FireGestures.FGgTranslator.optionJSON in the crash stats which I then found over here.

I can't recommend disabling these security prefs, just like I can't recommend or give much support to userChromeJS but if your content processes are crashing after a Nightly update today; this might be why.

@xiaoxiaoflood
Copy link
Owner

Thank you for reaching out.

I believe no code in this repo sets pref in content process, but it's good to know anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants