Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can make userchrome support subfolder such as subscript tabmixplus? #6

Open
GoogleBeEvil opened this issue Feb 5, 2019 · 5 comments

Comments

@GoogleBeEvil
Copy link

i noticed that only the files located in root of chrome will load,can make it support sub folders?

@xiaoxiaoflood
Copy link
Owner

I don't know subscript tabmixplus.

In fact, UCJS in subfolders were loaded in previous version, but I've removed this feature to simplify the code and because I don't see the point of not having all the UCJS in root. Some complex UCJS may need extra files, which should be placed in subfolders, but this is handled by the UCJS itself. Why do you need UCJS in subfolders?

Previous version with subfolders support (very bloated and old):
https://github.com/xiaoxiaoflood/firefox-scripts/blob/6aec93b50ae0ced692fcdd152cf17ceed848397b/chrome/userChrome.js
Forked from the original:
https://github.com/alice0775/userChrome.js/blob/master/userChrome.js

Current version:
https://github.com/xiaoxiaoflood/firefox-scripts/blob/master/chrome/utils/userChrome.jsm

rebuild_userChrome.uc.js was also very simplified and optimized:
c644d19#diff-afcd442200122c2173e71f7f2bfee5b3
Forked from the original:
https://github.com/alice0775/userChrome.js/blob/master/rebuild_userChrome.uc.js

@GoogleBeEvil
Copy link
Author

subscript tabmix were build-in folders that will be load *.uc.js in them
https://github.com/alice0775/userChrome.js/blob/master/userChrome.js#L79
the reason i need this is i can put uc.js in diffrent folder classified by diffrent function,if putting too much script .in root dir, the uc.js manager will have a long list that maybe need scroll to show which i wana turn on /of

@GoogleBeEvil
Copy link
Author

GoogleBeEvil commented Feb 8, 2019

BTW: there some uc.js file are not loaded whilesome other modified 57+ userchrome.js did.i am not code,maybe missing some jsm file? the addonpage as eg(add an icon in addon page to show uc.js file ).

https://github.com/GoogleBeEvil/userChrome.js/blob/master/files.7z

@xiaoxiaoflood
Copy link
Owner

xiaoxiaoflood commented Feb 8, 2019

Your AddonsPage.uc.js has compatibility restricted to alice0775's userChrome.js, as you can see by some references to userChrome_js, which inexist in my updated userChrome.jsm.

For instance, userChrome_js.scripts now is _uc.scripts. But you can't simply replace them, the structure has changed (mine is Object, alice0775's is Array, also Firefox no longer supports overlays...).

Sorry, but I made my userChrome.jsm to integrate with the UCJS I use (and vice versa). Other UCJS that are intended to be used with my userChromeJS should take this into account OR be generic enough to work without fixes.

And I don't see the point of use AddonsPage.uc.js when rebuild_userChrome.uc.js is better and does the same (toggle on/off, edit, delete).

In the long run I might implement UCJS autoupdate (like Greasemonkey's userscript updater and Stylish's userstyle updater), then I would recover something like AddonsPage.uc.js. Just maybe.

Back to the issue, sorry but at least for now I have no plan to rebuild subfolders support. But I'll keep it open because I can change my mind.

@GoogleBeEvil
Copy link
Author

ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants