Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] GoldenDict keep adding "&" in group name #1484

Open
cuongha0701 opened this issue Apr 28, 2024 · 2 comments
Open

[Bug] GoldenDict keep adding "&" in group name #1484

cuongha0701 opened this issue Apr 28, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@cuongha0701
Copy link

Describe the bug
GoldenDict keep adding "&" character in group name

To Reproduce
Steps to reproduce the behavior:

  1. Go to Edit
  2. Click on Dictionaries
  3. Click on Groups
  4. Click on OK | Apply button
  5. See error

Screenshots
Screenshot_20240428_115805

OS and software versions
KDE Plasma 6.0.4
Goldendict-ng 24.02.16.e78aff27 at 2024-04-24T04:58:00Z
Qt 6.7.0 GCC 13.2.1 20230801 arch linux 6.8.7-arch1-2 x86_64-little_endian-lp64
Flags: MAKE_ZIM_SUPPORT USE_ICONV MAKE_CHINESE_CONVERSION_SUPPORT

@shenlebantongying shenlebantongying added the bug Something isn't working label May 15, 2024
@shenlebantongying
Copy link
Collaborator

shenlebantongying commented May 15, 2024

Yes, I reproduced on KDE6 + Qt6.7. This is a KDE only bug.

The & has a special meaning https://doc.qt.io/qt-6/qshortcut.html#details for mnemonic shortcuts.

By holding Alt, the first group tab is highlighted, while the others are not, Alt+Z will jump to the first tab.

The first tab will trigger this bug.

image

KDE automatically modifies the text string to include a & for mnemonic shortcuts, and we do & escaping, which makes the modification persist.

Escaping on GD's side goldendict/goldendict@ed2876d

Previous similar bugs:

goldendict/goldendict#847
goldendict/goldendict#1031

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants