Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Last main window state is not saved on the Qt 6.4.2 Windows version #312

Closed
courrier1 opened this issue Jan 13, 2023 · 3 comments · Fixed by #404
Closed

Last main window state is not saved on the Qt 6.4.2 Windows version #312

courrier1 opened this issue Jan 13, 2023 · 3 comments · Fixed by #404
Labels
bug Something isn't working in future

Comments

@courrier1
Copy link

courrier1 commented Jan 13, 2023

When using the 6.3.2 version and closing the program while maximized for example, the next time I launch the program it is back to its previous state, while on 6.4.2 it appears in a default state.

How 6.4.2 main window appear after I close it while maximized:
Capture

And this is how the 6.3.2 appears:
Capture2

@shenlebantongying
Copy link
Collaborator

shenlebantongying commented Jan 19, 2023

We didn't change any of the code related to Window State.

It only happens in the Qt6 version, This might be a Qt Bug.

You can use the Qt5 version (aka 5.15.2-GoldenDict____) to avoid this.

@shenlebantongying shenlebantongying added bug Something isn't working in future labels Jan 19, 2023
@courrier1
Copy link
Author

I'm using the 6.3.2 version and it works fine, the problem is only with 6.4.x version.

@xiaoyifang
Copy link
Owner

the code of saveState and restoreState is in the mainwindow.cc
https://github.com/xiaoyifang/goldendict/blob/069714e3a2fd689969724d556ce24349697e3156/mainwindow.cc#L1094-L1095

more likely a qt bug.

xiaoyifang added a commit that referenced this issue Mar 20, 2023
fix #312

the reason is still unknown , when invoke the addNewTab, the window's size was reset to its default size
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working in future
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants