Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Widget: static widgets which return no data are incorrectly marked as faults and invalidate the layout #3309

Closed
dasgarner opened this issue Jan 16, 2024 · 1 comment
Assignees
Milestone

Comments

@dasgarner
Copy link
Member

dasgarner commented Jan 16, 2024

v4 adds logic which was intended for elements, so that if elements have no data we expire the layout and move on. This is done because elements have no concept of a "No Data Element" to be used when the widget returns no data.

However, static widgets already have a concept of "No data message" which should be used instead of expiring/faulting the widget.

For the avoidance of doubt, when we have a static widget (not elements) we should fault and expire if the requested file is a 404 (i.e. it isn't downloaded at all), but if it is downloaded with data: [] inside, we should continue to render the widget as normal.

@dasgarner
Copy link
Member Author

✅ tested

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants