Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layout Editor: positioning of background image behind region is wrong #3315

Closed
dasgarner opened this issue Jan 17, 2024 · 3 comments
Closed
Assignees
Milestone

Comments

@dasgarner
Copy link
Member

When clicking on the region shown below, you'd expect the background to resize and be positioned behind:

image

Instead it looks like this:

image

I believe this might be related to a change made in the Image widget: xibosignage/xibo-cms@138c270

If the designer window is smaller than the background image, it works:

image
@dasgarner dasgarner added this to the 3.3.10 milestone Jan 17, 2024
@dasgarner
Copy link
Member Author

@PeterMis I can't remember if the fix applied also effects v4, or whether this issue will be v3 only?

As for what we do - we probably ought to allow upsize in this case, but not in the case we applied the fix for 😄

@dasgarner dasgarner changed the title Layout Editor: positioning of background image behind region is wrong Layout Editor: positioning of background image behind region is wrong (possible v3 only) Jan 17, 2024
@PeterMis
Copy link
Member

@dasgarner It was added to the WidgetDownloader I believe, so it might need some condition for that there as well.

@dasgarner dasgarner changed the title Layout Editor: positioning of background image behind region is wrong (possible v3 only) Layout Editor: positioning of background image behind region is wrong Jan 18, 2024
@ifarzana
Copy link

✅ tested

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants