Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPM install dependency conflict #186

Closed
me-0xe opened this issue Jul 16, 2023 · 7 comments
Closed

NPM install dependency conflict #186

me-0xe opened this issue Jul 16, 2023 · 7 comments
Labels
dependencies Pull requests that update a dependency file

Comments

@me-0xe
Copy link

me-0xe commented Jul 16, 2023

Similar to this earlier issue Cannot install with NPM #182
There is a dependency conflict when installing via npm with the latest embla-carousel 8.0.0-rc7.

npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR! 
npm ERR! While resolving: embla-carousel-wheel-gestures@8.0.0-rc04
npm ERR! Found: embla-carousel@8.0.0-rc07
npm ERR! node_modules/embla-carousel

Suggestion
It looks like the other plugins endorsed by the docs are tagging a release with the same rc as the main embla-carousel package. Maybe using the same approach when bumping the dependancy could help prevent future confusion for integrators?

Screenshot 2023-07-17 at 11 35 06 AM

@sha237gh
Copy link

+1, having the same problem. is there any way around this?

@georgezikos
Copy link

@sha237gh I just had it ignore the peer dependencies and install anyway using npm install embla-carousel-wheel-gestures --save --legacy-peer-deps and it seems to work just fine.

@coreybrendan
Copy link

Hey, gang! I'm also experiencing this conflict when attempting an npm install (on the latest version of Embla). Wondering if there's a fix queued for this issue? My team is wary of introducing a --legacy-peer-deps into prod.

@hellomkreyes
Copy link

Experiencing the same problem as well! I want to implement the plugin in a production codebase, so I kinda want to avoid having to use the --legacy-peer-deps workaround.

@davidjerleke
Copy link
Collaborator

Hi @hellomkreyes, @coreybrendan, @me-0xe, @georgezikos, @sha237gh.

I think we need to add a tilde (~) sign before the package version here to avoid this happening every time a new minor version of embla-carousel is released.

Feel free to open a PR for this.

Best,
David

@davidjerleke davidjerleke added the dependencies Pull requests that update a dependency file label Sep 30, 2023
@xiel
Copy link
Owner

xiel commented Sep 30, 2023

Sorry had busy weeks, should be fixed now. I was not aware the tilde would work for prereleases. 🙏

Please try again with embla-carousel-wheel-gestures@8.0.0-rc05 📦
I tested it with yarn and npm (9.5.1) and it worked like that.

Cheers and thanks for your patience.

@me-0xe
Copy link
Author

me-0xe commented Nov 17, 2023

Thanks for the response. Appreciate the effort that goes into Embla and the plugins!

@me-0xe me-0xe closed this as completed Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

No branches or pull requests

7 participants