Skip to content
This repository has been archived by the owner on Apr 7, 2024. It is now read-only.

SelectAsyncメソッドの引数null許容の一貫性が無い #32

Closed
AveMarina opened this issue Jan 20, 2016 · 0 comments
Closed

SelectAsyncメソッドの引数null許容の一貫性が無い #32

AveMarina opened this issue Jan 20, 2016 · 0 comments
Assignees
Labels

Comments

@AveMarina
Copy link

①.引数の定義と実処理の一貫性
IDbConnectionExtensions.SelectAsyncにおいて、
引数propertiesがoptional(default = null)であるにも関わらず、メソッド内部にてnull判定を行い、
ArgumentNullExceptionをスローします。

②.IDbConnection/IDbTransactionにおける①の一貫性
①の問題は、IDbTransactionExtensions.SelectAsyncでは発生しません。

⇒①のnullチェックを排除し、nullであれば全列を取得対象とする挙動が正しいと思われます。

@xin9le xin9le added the bug label Jan 20, 2016
@xin9le xin9le self-assigned this Jan 20, 2016
@xin9le xin9le closed this as completed in 7fd63f6 Jan 22, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants