Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove function duplicate #121

Open
JoeSSS opened this issue Jan 1, 2018 · 0 comments
Open

Remove function duplicate #121

JoeSSS opened this issue Jan 1, 2018 · 0 comments

Comments

@JoeSSS
Copy link
Contributor

JoeSSS commented Jan 1, 2018

waitingForFile function is duplicated in two view controllers:

https://github.com/xing/calabash-launcher/blob/master/Launcher/Classes/ViewControllers/ElementConstructorViewController.swift#L56

https://github.com/xing/calabash-launcher/blob/master/Launcher/Classes/ViewControllers/InspectorViewController.swift#L196

The only difference between two is different UI element animation triggering.

@JoeSSS JoeSSS added this to the Calabash Launcer 3.0 milestone Jan 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant