Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stragen generation with provided checkpoints #1

Closed
JialeTao opened this issue Jun 6, 2022 · 3 comments
Closed

stragen generation with provided checkpoints #1

JialeTao opened this issue Jun 6, 2022 · 3 comments

Comments

@JialeTao
Copy link

JialeTao commented Jun 6, 2022

Hi, thanks for sharing the good work. I used the provided checkpoints celeb_wild_k8 and taichi_k10 to generate images. It seems both the results are strange and are not natural images. I show some cases in the following.

celeb
0
1

taichi
0
1

BTW, I use the torch version 1.6.

@xingzhehe
Copy link
Owner

xingzhehe commented Jun 6, 2022

Thanks for bringing this up. It took me quite some time to fix. Please check the latest version.

I believe this is a bug caused by my code cleaning. BTW, even now, I don't know why it causes a bug since it is just a different writing way. You can check the self.gen_keypoints_embedding_noise, self.gen_keypoints_layer and self.gen_background_embedding in generator.py.

If you got any further problems, don't hesitate to contact me.

@JialeTao
Copy link
Author

JialeTao commented Jun 6, 2022

Thanks for quick reply! After modify these three components, it works now.

It seems the generated images are much more natural now, but there still exists many artifacts, and some bodies are deformed. Is this normal? Since some parts are missed, does it hurt the performance on the segmentation?

39
40
41
42
43
44

@xingzhehe
Copy link
Owner

I unrolled all the modules to hard-coded ones (please update). It works better now. I doubt it is a bug in Pytorch, not sure if it is due to the version.

There are still artifacts, which is normal since I do not use any path regularization or EMA or EqualLinear for simplifity. It may harm the quality of segmentation, but we just found the current one is enough for a SOTA performance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants