Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fully parameterize by-chromosome functionality in ctwas_rss | impute_expr_z maybe also need small tweak to accomodate #8

Open
shugamoe opened this issue Oct 5, 2023 · 1 comment

Comments

@shugamoe
Copy link
Contributor

shugamoe commented Oct 5, 2023

I've found it convenient when using cTWAS with sQTL models across multiple tissues (~20k models per tissue) to customize cTWAS to allow for by chromosome ctwas_rss parameter estimation/fine-mapping so that I'm not waiting more than 24 hours for a single tissue to finish running on one computer (even with single node parallelization), but instead waiting under that time for 22 chromosomes to finish independently instead.

Below is a link to some of the little hacks I made to allow for this functionality before the latest round of updates like pre-harmonization, separate parameter estimation/fine-mapping. (Some small messing around with the impute_expr_z output is required as well.)
multigroup...shugamoe:ctwas:multigroup_dev

I will update this issue with the appropriate branch from my fork when I port these hacks over to the latest multigroup updates that have been made, but I think it would be nice for ctwas_rss to be parameterized to allow for at least param. estimation and finemapping by chromosome. I am aware of an example Wesley made to run ctwas for a single region, but I'm not a fan of also having to subset the .db model as well. Now that parameter estimation and fine-mapping can be separated, it might even make sense to do genome-wide parameter estimation, but by-chromosome fine-mapping/final PIP calculations (with each chromsome on a multicore node).

Ideally, it would be nice if when specifying chromosome in impute_expr_z (already possible), that the output for this is able to transfer smoothly to ctwas_rss so that a chromosome can be run singly in that function as well. I.e. modify ld_exprfs from impute_expr_z results if a chromosome is specified, so that it can integrate more smoothly into a chromosome parameterized ctwas_rss function.

@shugamoe shugamoe changed the title Fully parameterize by-chromosome functionality in ctwas_rss | impute_expr_z maybe also needs small tweak Fully parameterize by-chromosome functionality in ctwas_rss | impute_expr_z maybe also need small tweak to accomodate Oct 5, 2023
@shugamoe
Copy link
Contributor Author

shugamoe commented Oct 19, 2023

shugamoe@766ed9c

This branch/commit is based off of the latest xinhe-lab/ctwas/multigroup and addresses the by-chromosome functionality (but not the tweak to ld_exprfs) as well as #7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant