Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid XML supplied by Icecast statistics #3

Closed
kenrestivo opened this issue Jan 26, 2016 · 4 comments
Closed

Invalid XML supplied by Icecast statistics #3

kenrestivo opened this issue Jan 26, 2016 · 4 comments

Comments

@kenrestivo
Copy link

Icecast version 2.3.3-2ubuntu1.14.04.1 , when reporting statistics via API calls to http://%s:%d/admin/stats.xml, returns this invalid XML:

<icestats><source mount="/radio"><Listeners>1</Listeners><listener><IP>23.2.9.2</IP><UserAgent>Mozilla/5.0 (iPhone; CPU iPhone OS 8_3 like Mac OS X) AppleWebKit/600.1.4 (KHTML, like Gecko) Mobile/12F70 [FBAN/FBIOS;FBAV/46.0.0.54.156;FBBV/18972819;FBDV/iPhone5,3;FBMD/iPhone;FBSN/iPhone OS;FBSV/8.3;FBSS/2; FBCR/AT&T;FBID/phone;FBLC/en_US;FBOP/5]</UserAgent><Connected>0</Connected><ID>2634887</ID></listener></source></icestats>

Note the unescaped &T; which is an undefined XML entity "T", and causes parsers to explode.

Expected behavior: text inside blocks should be html escaped or enclosed in a CDATA block, if I remember my XML correctly.

@dm8tbr
Copy link
Contributor

dm8tbr commented Jan 26, 2016

Please verify on latest Icecast. A lot has changed since 2.3.3.
https://wiki.xiph.org/Icecast_Server/Installing_latest_version_%28official_Xiph_repositories%29

@dm8tbr
Copy link
Contributor

dm8tbr commented Jan 26, 2016

Had some time to spare. Verified on latest trunk.
Moving ticket to trac.xiph.org, where we track all Icecast issues:
https://trac.xiph.org/ticket/2255#ticket

@dm8tbr dm8tbr closed this as completed Jan 26, 2016
@ePirat
Copy link
Contributor

ePirat commented Feb 9, 2016

This is fixed now, see commit d739c65. Thanks for the report!

@kenrestivo
Copy link
Author

Great, thanks for the quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants