Unresolved external symbols when building with UWP

[GregSlazinski]

I'm getting unresolved external symbols when compiling in following cases:

CreateFileA CreateFileW from here: https://github.com/xiph/flac/blob/master/src/libFLAC/windows_unicode_filenames.c
when compiling on Windows Universal Platform (UWP does not have CreateFileA CreateFileW, it only has CreateFile2)

flac_max flac_min from here:
https://github.com/xiph/flac/blob/master/src/libFLAC/include/private/macros.h
when compiling on Android with latest Android NDK (Clang)

there are so many options in that file, but can you just keep it simple to one version in all cases:

#define flac_min(a,b) ((a) <= (b) ? (a) : (b))
#define flac_max(a,b) ((a) >= (b) ? (a) : (b))

[erikd]

Was a bit confused about the relationship between Windows and Android. Then I figured out this was actually two questions.

The first question about unresolved external symbols is not one I can answer. The existing code does compile and run on standard windows. If Windows Universal Platform is different in some way from standard Windows then someone needs to provide support for that.

With regard to the implementations of flac_min etc you say:

there are so many options in that file, but can you just keep it simple to one version in all cases:

I disagree. The first version uses GCC's __typeof__ operator to provide a level of type safety that is not possible with what you suggest.

[GregSlazinski]

CreateFileA and CreateFileW need to be replaced with CreateFile2 on UWP

on Android the flac_min and flac_max are simply not defined at all, so the compilation/linking process fails.

[erikd]

The flac_min/flac_max issue is fixed in https://git.xiph.org/?p=flac.git;a=commit;h=64f47c2d71ffba5aa8cd1d2a447339fd95f362f9

[erikd]

I've mentioned the UWP problem on the flac-dev mailing list and linked to this issue.

[ktmf01]

@GregSlazinski Quite a bit has changed with the UTF-8 code, is this still an issue?

[ktmf01]

Several patches for UWP are supplied here: https://gitlab.xiph.org/xiph/flac/-/merge_requests/1

It seems however users of UWP are encouraged to migrate: https://www.techradar.com/news/microsoft-is-finally-dropping-uwp-app-support-windows-app-sdk-heres-why

Because of that, I'm not sure whether rebasing and integrating these patches is worth the hassle.

[ktmf01]

This has been fixed with the merge of #457