Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flac 1.4.0 encoding slowdown when used in CinelerraGG? #450

Closed
Randrianasulu opened this issue Sep 14, 2022 · 3 comments
Closed

flac 1.4.0 encoding slowdown when used in CinelerraGG? #450

Randrianasulu opened this issue Sep 14, 2022 · 3 comments

Comments

@Randrianasulu
Copy link

Hello!

we tried to upgrade our copy of FLAC library from 1.3.2 to 1.4.0 and got quite unexpected slowdown, more than 2x!

Application's code:
https://git.cinelerra-gg.org/git/?p=goodguy/cinelerra.git;a=summary

especially see cinelerra/fileflac.C

you need to replace flac tarball in thirdparty/src and patch configure.ac

may be our API usage was slightly wrong before and now it just become much more visible speed-wise? Sorry, not really programmer enough (

our maillist thread where 2x sliwdown was reported
https://www.mail-archive.com/cin@lists.cinelerra-gg.org/msg04787.html

@ktmf01
Copy link
Collaborator

ktmf01 commented Sep 15, 2022

What compiler are you using? Have you also compared resulting filesizes or only speed?

@ktmf01
Copy link
Collaborator

ktmf01 commented Sep 15, 2022

I see here that no compression level is set. This means Cinelerra is probably affected by this change: 7b73bbc

In effect, it means the default compression level changed from 0, the initialization value, to 5, which is the intended default. With music-like sources, you should see a compression improvement of about 10%. If you rather have faster compression instead of better compression, just add FLAC__stream_encoder_set_compression_level(0) just before FLAC__stream_encoder_init_file

@Randrianasulu
Copy link
Author

Randrianasulu commented Sep 16, 2022

oh, it seems we were bitten by default debug=yes. disabling debug give our speed back, it seems.

Thanks! (as side effect of this I even implemented compression level choice GUI for our program! so, win after all)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants