Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it possible to change supported FRAME_SIZE? #93

Open
Ornolfr opened this issue Sep 27, 2019 · 3 comments
Open

Is it possible to change supported FRAME_SIZE? #93

Ornolfr opened this issue Sep 27, 2019 · 3 comments

Comments

@Ornolfr
Copy link

Ornolfr commented Sep 27, 2019

Thank you for this spectacular library! It is a very powerful tool that can be used in real time for real world applications.

However, in Android, the frame size may vary per device and API being used (Java SDK, OpenSL ES, AAudio) basis - from less than 150 up to thousands of values in buffer. The library supports only 480 as the frame size and crashes/produces audio glitches when I send the audio buffer to processing.

Is it possible to make the frame size variable?

@Ornolfr
Copy link
Author

Ornolfr commented Sep 27, 2019

I've tried to change the FRAME_SIZE, WINDOW_SIZE, FREQ_SIZE, PITCH_MIN_PERIOD, PITCH_MAX_PERIOD, PITCH_FRAME_SIZE and PITCH_BUF_SIZE based on the current frame size of the audio buffer but still the app crashes randomly and there are audio glitches.

@LikeSwim
Copy link

我也在更改FRAME_SIZE我猜想可能数据的预处理部分(提取特征的部分)也需要更改,崩溃原因可能出现在pitch_filter函数里

@wegylexy
Copy link
Contributor

wegylexy commented Jun 28, 2020

See https://github.com/wegylexy/rnnoise_wasm/tree/master/src/worklet.c for dynamic buffer size.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants