Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oggenc: mention resample method in manual #15

Open
HybridDog opened this issue Nov 6, 2017 · 1 comment
Open

oggenc: mention resample method in manual #15

HybridDog opened this issue Nov 6, 2017 · 1 comment

Comments

@HybridDog
Copy link

https://github.com/xiph/vorbis-tools/blob/master/oggenc/man/oggenc.1#L162
How does sound become resampled if I use the --resample parameter, is the resampling mechanism optimized for the upcoming ogg compression or can I get better results if I resample the sound with sox instead of oggenc's resampling?

@rillian
Copy link
Contributor

rillian commented Nov 6, 2017

It uses a sinc-filtered resampler with a Kaiser window, based on Hanning's textbook. It's an earlier version of the speex resampler used in opusenc, firefox and a number of other tools. In my experience it's fine, and you don't need to do special resampling ahead of time.

@tdaede should vorbis-tools adopt the speex resampler implementation? Should be faster, if nothing else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants